[Libguestfs] Re: [PATCH nbdkit] tests: gcs: skip tests without google cloud module

On 2024-04-28 17:09:06+0000, Richard W.M. Jones wrote: > On Sun, Apr 28, 2024 at 05:44:53PM +0200, Thomas Weißschuh wrote: > > The gcs plugin uses the google cloud module and can't work without it. > > Skip the test if the module is unavailable. > > > > Signed-off-by: Thomas Weißschuh <thomas(a)t-8ch.de&gt; > > --- > > tests/test-gcs.sh | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tests/test-gcs.sh b/tests/test-gcs.sh > > index ed823377dc5a..9b165e8159be 100755 > > --- a/tests/test-gcs.sh > > +++ b/tests/test-gcs.sh > > @@ -40,6 +40,7 @@ requires $PYTHON --version > > requires_nbdcopy > > requires_plugin python > > skip_if_valgrind "because Python code leaks memory" > > +requires $PYTHON -c 'import google.cloud' > > It shouldn't do (I think?) ... Did you see: > > https://gitlab.com/nbdkit/nbdkit/-/commit/aca30111632091bbc91096f19638b9e... I do have that commit, and I don't have that module installed. The actual problem is the import of "google.api_core", which itself is part of google-api-core which I don't have installed. That is a very narrow band of platforms this test can run on.