Re: [Libguestfs] [PATCH] v2v: Log full imageio response on failure.
On Tue, Jun 05, 2018 at 09:35:34PM +0300, Nir Soffer wrote:
> + # Log the full error if we're verbose.
> + debug("unexpected response from imageio server:")
> + debug(msg)
> + debug("%d: %s" % (status, reason))
> + debug(body)
>
Hiding fatal error in non-verbose will make it hard to support.
A quick note that we're always in debug mode when run under oVirt.
I'll fix the rest of the stuff and post an updated patch.
Thanks for the comprehensive review,
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html