Re: [Libguestfs] [PATCH nbdkit v2] server: utils: Make nbdkit_parse_size to reject negative values

From: Nikolay Ivanets <stenavin(a)gmail.com&gt;

nbdkit_parse_size() uses strtoumax() function to parse input strings which states:

1. Some more tests were added to cover described behaviour. 2. Input strings where grouped into a set which lead to valid/invalid/negative/overflow result. 3. Some strings with a leading '+' sign were added. ---

errno = 0; - size = strtoumax (str, &end, 10); - if (errno || str == end) { + size = strtoimax (str, &end, 10); + if (str == end) { nbdkit_error ("could not parse size string (%s)", str); return -1; } + if (size < 0) { + nbdkit_error ("size cannot be negative (%s)", str); + return -1; + } + if (errno) { + nbdkit_error ("size (%s) exceeds maximum value", str); + return -1; + }