Re: [Libguestfs] [p2v PATCH 09/10] rely on Linux for killing nbdkit, when the parent thread exits
On Thu, Mar 31, 2022 at 03:35:55PM +0200, Laszlo Ersek wrote:
And yes, that's the crux: if we need to keep the PID tracking /
killing
/ reaping (and I agree that we do!), then what does "--exit-with-parent"
buy us? I don't think it improves anything. So if I can't remove the PID
tracking (and I agree I shouldn't), I'd just forget about
"--exit-with-parent" and drop this patch altogether.
I think we can argue if it's worth the effort to add it (given how
virt-p2v is used in the real world), but the feature certainly does
something: If virt-p2v goes away without killing nbdkit, eg. it
segfaults, then --exit-with-parent is a second chance to clean up
nbdkit. In practice it's pretty reliable.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines. Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v