Re: [Libguestfs] [nbdkit PATCH 2/4] tests: Test retry with different fua/fast-zero flags
On Wed, Oct 02, 2019 at 09:50:45PM -0500, Eric Blake wrote:
+case "$1" in
+ open)
+ # Count how many times the connection is (re-)opened.
+ read i < retry-zero-flags-open-count
+ echo $((i+1)) > retry-zero-flags-open-count
+ ;;
+ can_write | can_zero) exit 0 ;;
+ can_fua)
+ read i < retry-zero-flags-open-count
+ case $i in
+ 1 | 4 | 5) echo native ;;
+ *) echo none ;;
+ esac
Whitespace problem?
This answers the question I had in the first patch: how can it
possibly happen that can_fua changes on a retry. It seems unlikely a
real plugin would be written like this, but obviously it's possible :-(
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top