Re: [Libguestfs] [PATCH v2v 0/2] output: Remove -o json mode [in stages]

On 04/11/22 12:34, Laszlo Ersek wrote: > On 04/11/22 12:11, Richard W.M. Jones wrote: >> I'd like to remove the unused -o json mode. The implementation is >> over-complicated and the only potential user (KubeVirt) isn't using it >> now and would be better off with a proper -o kubevirt mode, which I'm >> going to implement later. >> >> My plan would be to add the patches in two stages. The first patch, >> which only removes the documentation but leaves the feature and test, >> would be applied to stable branch virt-v2v 2.0. The second patch >> would be go on the development branch 2.1 (which hasn't yet been >> created). The first stable release without this feature would be 2.2. > > If the second patch goes on the 2.1 dev branch, then why wouldn't the > 2.1 release include it? (IOW the 2.1 release would not have "-o json" > any more.) > > I'm OK with the plan just don't understand how 2.2 is relevant. Ah, having read the first commit message, I think the typo could be the other way around: you may have meant the 2.2 dev branch (which doesn't yet exist because there hasn't been a 2.1 release yet). The 2.1 dev branch is already open OTOH, IIUC.