Re: [Libguestfs] [PATCH 2/5] macosx: Add definition of program_name for gnulib

On 11 February 2015 at 13:46, Richard W.M. Jones <rjones(a)redhat.com&gt; wrote: [...] > On non-glibc, error.c says: > > /* The calling program should define program_name and set it to the > name of the executing program. */ > extern char *program_name; > > This indicates to me that we shouldn't define `program_name' as a symbol > in libguestfs. Instead every libguestfs-using program should define > it. For example, virt-df (df/main.c) would have: > > #if /* this is Mac OS X */ > char *program_name = "virt-df"; > #endif > > That sucks a lot. That was my first approach, but adding a Darwin-specific ifdef to every executable shipped with libguestfs seemed much more intrusive than sneaking it in as a symbol in the library. I do see your point, though. Proposing a patch to gnulib, even should they accept it, does not fix the underlying issue, which is, essentially, that gnulib requires that symbol and libguestfs binaries don't supply it. There might be another OS that trips over this, after all.