Re: [Libguestfs] [libnbd PATCH] Fix building with for ocaml < 4.06.0
On Wednesday, 12 June 2019 13:27:34 CEST Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
---
Notes:
This is the simplest solution suggested to me by Rich and it works.
Most of autotools are not friends with me, so the other approach I tried, with
requiring at least OCaml 4.05.0, having this fix in only for OCaml < 4.06.0 and
properly detecting and reporting that, was a bit ugly.
You can see the configure.ac part of it here: http://ix.io/1L0o
It is not that bad IMHO -- just ignore the "micro" part of the version,
as it not needed, and use a similar approach of libguestfs:
https://github.com/libguestfs/libguestfs/blob/master/m4/guestfs-ocaml.m4#L41
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)