Re: [Libguestfs] nbdkit test-checkwrite.sh failing occasionally on ppc64le
On 07/19/22 16:17, Richard W.M. Jones wrote:
Note I'm not claiming the assertion will not fail! Just that
the
assertion is correct, and if it fails we've got a bug.
Fair enough, but how do we explain the second paragraph of the leading comment on the
function then?
* Note we don't check that the extents exactly match since a valid
* copying operation is to either add sparseness (qemu-img convert -S)
* or create a fully allocated target (nbdcopy --allocated).
I think it directly contradicts the assertion. That, or I don't understand the comment
at all.
(It's from commit 2d0954dd6431, "New filter: checkwrite", 2020-12-22.)
Laszlo