Re: [Libguestfs] [PATCH REBASED] Remove main loop

On 14/09/09 13:37, Richard W.M. Jones wrote: > In theory, but our advice for packagers (on non-Debian, non-Red Hat > distributions) has been to pull the Fedora binary appliance out of the > packages: > > http://libguestfs.org/FAQ.html#distros Then give it a bigger version bump and stick a release note in ;) > Also you can set LIBGUESTFS_PATH and point it to any appliance you > want, and most likely it will work. > > Anyhow, changing the protocol itself (which is very well tested) is > outside the scope of this patch. This patch invalidates all that testing, because it effectively changes the entire implementation of the protocol. I suggest that this is a perfect opportunity to also fix the protocol, if not in this patch, then in one to follow closely afterwards. The cancellation of file sends is certainly broken at the protocol level. Everywhere we ignore cancellation messages in the implementation is simply an indication of this.

It's broken because there's no ACK at the end of a successful send, which means that the host cannot know if the file was successfully written to the guest or not unless the write fails before the end of the transmission.