Re: [Libguestfs] [PATCH 3/7] add_drive: Add selinuxnorelabel optional boolean.
On Thu, 2013-02-28 at 10:57 +0000, Richard W.M. Jones wrote:
From: "Richard W.M. Jones" <rjones(a)redhat.com>
If set, this causes <seclabel model=selinux relabel=no> to be added to
the disk element in the libvirt XML.
It has no effect *except* on the libvirt attach method when SELinux
and sVirt is being used.
---
generator/actions.ml | 8 +++++++-
src/guestfs-internal.h | 1 +
src/launch-libvirt.c | 20 ++++++++++++++++++++
src/launch.c | 21 ++++++++++++++-------
4 files changed, 42 insertions(+), 8 deletions(-)
Is there any instance where we would *not* want to do this? Off the top
of my head, I can't think of a good reason for libguestfs to be in the
business of relabelling drives. Can we not just hard-code this off?
If, on the other hand, there is a good reason to make this option, I
think it should be explained in the docs below.
Matt