Re: [Libguestfs] [PATCH] New APIs: hopen-device hopen-file hread hwrite hseek hclose hclose-all
On 26/08/10 13:52, Richard W.M. Jones wrote:
It's not really much of a test, writing and reading 4 bytes.
It's supposed to exercise the libguestfs code, rather than the
implementations of open, read, write and close. Just making the string
longer doesn't really add anything to the existing coverage.
Aligned vs unaligned?
Seeking and writing in a large sparse file?
Writing past the end of a large file?
I don't think the above are interesting to test as their behaviours are
well defined elsewhere.
Writing past the end of a device?
That's a potentially interesting test of error handling, though.
Reading and writing large buffers (just below 2MB and over 4MB, the
latter should fail gracefully).
I ought to be testing that. I'll add it.
I agree with all the rest of the review comments. Patch coming up at
some point.
Matt
--
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team
GPG ID: D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490