Re: [Libguestfs] [PATCH nbdkit 2/2] vddk: Relax thread model to PARALLEL and implement a disk handle pool.

On Thu, Aug 6, 2020 at 7:24 PM Richard W.M. Jones <rjones(a)redhat.com&gt; wrote: There are 2 issues: 1. We create the connection and handle with uninitialized memory, and later with memory used by the previous connection/handle. This may not matter if the library initializes all fields of the struct, but it is safer to zero the memory. 2. We create the handlers in request threads, so most likely not in the same thread. This may be ok, but risky. I moved the creation of all connections and handles to populate_pool(), called from vddk_open(). This may create more connections and handles than needed if the client does not use multiple inflight requests, but this is not important now. The code compiles but I cannot test it. Does it make any difference? Nir