Libguestfs July 2024

guestfs@lists.libguestfs.org

2 participants
3 discussions

Re: [External] Re: [PATCH] VxFS Filesystem support to libguestfs

by Richard W.M. Jones

On Mon, Jul 01, 2024 at 11:24:59AM +0000, Ravi Singh wrote: > A few basics first: > > - The commit doesn't have an author name. : Fixed > > - The commit has no information at all about the change. : Fixed This commit message is just a list of what changed, which is not how to write good commit messages. (Also the summary line is bad too). There are numerous examples of good commit messages in the Linux kernel repository: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/?s... and a long discussion here: https://www.kernel.org/doc/html/latest/process/submitting-patches.html > - One file at least has whitespace problems, adding empty lines at > the end of the file. : Fixed > > - There are no tests at all. : In progress. > > - Copyright dates are not 2024. : Fixed. > > - Make the first line of the top comment be about the file, not just > something that was copied and pasted.: Please point out which file. Most of them ... > And let's think about how to split up the commits to make a story: This isn't fixed either. Think about telling a story. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com nbdkit - Flexible, fast NBD server with plugins https://gitlab.com/nbdkit/nbdkit

4 days, 15 hours

1
0
0 / 0

Re: [External] Re: [PATCH] VxFS Filesystem support to libguestfs

by Richard W.M. Jones

On Mon, Jul 01, 2024 at 06:56:40AM +0000, Ravi Singh wrote: > Hi Richard, > > As discussed, I have created a fork from the master branch and updated it with > my patch. Here are the details of the testing I conducted: > > 1. Ran `make quickcheck`: Please find the attached log file for the results. > 2. Ran `make check`: A few tests are failing on my system due to issues with > Fedora and SQLite configurations. The log file for this test is also attached. > > You can find the forked branch at the following link: https://github.com/rsingh-veritas/libguestfs.git A few basics first: - The commit doesn't have an author name. - The commit has no information at all about the change. - One file at least has whitespace problems, adding empty lines at the end of the file. - There are no tests at all. - Copyright dates are not 2024. - Make the first line of the top comment be about the file, not just something that was copied and pasted. And let's think about how to split up the commits to make a story: https://people.redhat.com/rjones/how-to-supply-code-to-open-source-projects/ (section 3) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v

4 days, 15 hours

2
1
0 / 0

Re: [External] Re: [PATCH] VxFS Filesystem support to libguestfs

by Richard W.M. Jones

I think the last version was posted in November. I don't think it made it to the mailing list, but I've attached a copy of the patch. A concrete way to proceed here is to: (1) Fork the project on github and add your patch to your fork. (2) Make sure it is up to date with the current branch. (3) Make sure it compiles and all the tests pass. (4) Post a link to the github repo here and we can look at it. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v

4 days, 19 hours

2
1
0 / 0

← Newer
1
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

Libguestfs July 2024