Either patch 1 or patch 2 in isolation is sufficient to fix the
problem that Rich forwarded on from an archlinux tester (name so I can
credit them?). But both patches should be applied, as well as
backported to appropriate stable branches, to maximize cross-version
interoperability of nbdkit vs. plugins. Patch 3 will let us detect
future similar bugs much faster. I want patch 4 to ensure that we
guarantee our API in the future, but it isn't finished yet.
Then I still need to follow up with my threat to remove nbd-standalone
for 1.20 (relying on libnbd is a lot easier now than it was when we
first added optional libnbd support in 1.14).
Eric Blake (4):
server: Normalize plugin can_* values
nbd: Normalize return values of can_*
tests: Don't let test-parallel-* hang on nbdkit bug
RFC tests: Add test to cover unusual .can_flush return
tests/Makefile.am | 21 +++++++
server/plugins.c | 24 ++++---
plugins/nbd/nbd-standalone.c | 12 ++--
tests/test-flush.sh | 85 +++++++++++++++++++++++++
tests/test-parallel-file.sh | 19 +++---
tests/test-parallel-nbd.sh | 13 ++--
tests/test-parallel-sh.sh | 19 +++---
tests/test-flush-plugin.c | 119 +++++++++++++++++++++++++++++++++++
8 files changed, 275 insertions(+), 37 deletions(-)
create mode 100755 tests/test-flush.sh
create mode 100644 tests/test-flush-plugin.c
--
2.25.1