Re: [Libguestfs] [libnbd PATCH] golang: Bump minimum Go version to 1.17

> > > I'm not sure what is the purpose of this test - requiring the Go > version is > > > good > > > enough since the code will not compile with an older version. EVen if > it > > > would, > > > it will not compile without unsafe.Slice so no special check is needed. > > Turns out it does matter. On our CI system, Ubuntu 20.04 has Go > 1.13.8 installed, and without this feature test, it compiled just fine > (it wasn't until later versions of Go that go.mod's version request > causes a compile failure if not satisfied). > How does it compile when unsafe.Slice is undefined? Quick test with unrelated test app: $ go build; echo $? # cobra-test ./main.go:10:6: undefined: cmd.NoSuchMethod 1 Or you mean the compile test for configure works and we want to make the configure test fail to compile?