Re: [Libguestfs] [PATCH] virt-v2v: Support for Converting VirtualBox Guests
Hi,
> + # Uninstall VirtualBox Guest Additions
> + foreach my $app (@$apps) {
> + my $name = $app->{app_name};
> +
> + if ($name eq "virtualbox-guest-additions") {
> + _remove_application($name, $g);
Can you rebase this to the latest upstream? _remove_application() became
_remove_applications(). Can you store up the apps to be removed and
uninstall them all in a single transaction?
right, I had missed that change since my first patch - I've updated the
patch to be similar as the Xen code.
Do you know if it's possible to uninstall VirtualBox after
conversion? I
actually have code locally to do this for VMware tools, but it doesn't
work because the VMware tools uninstaller is brain dead. If VirtualBox
isn't brain dead we could integrate this too.
Yes, the uninstaller works fine also after conversion. If you do not
remove the Guest Additions during conversion and boot with them on KVM
you'll see errors from VirtualBox kernel modules complaining about the
missing VirtualBox PCI device alongside few services starting up.
This looks great. If you could do the rebase to fix
_remove_application() I'll push it as-is. We can think about Windows later.
Please see the updated patch attached.
Thanks,
--
Marko Myllynen
Attachments:
- 0001-virt-v2v-Support-for-Converting-VirtualBox-Guests.patch (text/plain — 4.7 KB)