Re: [Libguestfs] [PATCH libguestfs] Use AC_HEADER_MAJOR to find definitions of major, minor, makedev.
On Wednesday, 1 March 2017 13:20:02 CET Richard W.M. Jones wrote:
Note this requires either the following fix in autoconf:
http://git.savannah.gnu.org/cgit/autoconf.git/commit/?id=e17a30e98
OR gnulib sys_types module plus gnulib
commit a512e041120e9012e69afa2f5c3adc196ec4999a (any gnulib more
recent than Sep 2016) which corrects the AC_HEADER_MAJOR macro in a
similar way.
---
Theoretically LGTM -- OTOH, couldn't the common #if..etc chain be put
in some common headers, e.g. guestfs-internal-all.h? Or a simple
guestfs-internal-majorminor.h or so.
Thanks,
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)