On Mon, Sep 17, 2012 at 10:47:52AM +0200, Jim Meyering wrote:
There's something wrong with check matching test-tool.c.
Thank you. That is another regexp that can be improved: [the ":" was trying to anchor that "#" to beginning of line in the grep-style "FILE:...text" output that it's filtering, but that is wrong for two reasons: your example is one, but the other is that the "#" need not be at the beginning of the line.]
diff --git a/top/maint.mk b/top/maint.mk index 4627bc5..f77d0c1 100644 --- a/top/maint.mk +++ b/top/maint.mk @@ -330,7 +330,7 @@ sc_prohibit_atoi_atof: sp_ = strcmp *\(.+\) sc_prohibit_strcmp: @prohibit='! *strcmp *\(|\<$(sp_) *[!=]=|[!=]= *$(sp_)' \ - exclude=':# *define STRN?EQ\(' \ + exclude='# *define STRN?EQ\(' \ halt='replace strcmp calls above with STREQ/STRNEQ' \ $(_sc_search_regexp)
Test and confirmed working. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://et.redhat.com/~rjones/virt-df/