On Tue, Sep 12, 2017 at 06:42:11PM +0200, Pino Toscano wrote:
On Wednesday, 9 August 2017 19:23:39 CEST Richard W.M. Jones wrote:
hivex has a function hivex_value_string. We were not calling it under the mistaken belief that because hivex implements this using iconv, the function wouldn't work inside the daemon. Instead we reimplemented the functionality in the library.
This commit deprecates hivex_value_utf8 and removes the library side code. It replaces it with a plain wrapper around hivex_value_string.
Thanks: Pino Toscano ---
The only thing here is that I would leave hivex_value_utf8 as non-daemon function, just to avoid adding an extra daemon function.
The saving in code on the library side is quite significant: lib/hivex.c | 111 --------------------------------- plus it's pretty ugly code since it has to use iconv ... Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top