On Wed, Sep 30, 2015 at 02:05:59PM +0200, Pino Toscano wrote:
On Tuesday 29 September 2015 22:06:13 Richard W.M. Jones wrote:
I used ESR's deheader program to look for unused includes. I then examined each instance by hand, and also test-compiled (on Linux).
Mostly LGTM, there just a couple of notes below:
--- a/src/fuse.c +++ b/src/fuse.c @@ -21,7 +21,6 @@ #include <stdio.h> #include <stdlib.h> #include <unistd.h> -#include <errno.h>
EINVAL is used here.
Yup. Also we need to include <errno.h> in any file that uses guestfs_int_program_name. I'll fix both.
--- a/src/launch-direct.c +++ b/src/launch-direct.c @@ -31,8 +30,6 @@ #include <sys/stat.h> #include <signal.h> #include <sys/socket.h> -#include <sys/un.h>
Isn't this needed by sockaddr_un?
Fixed too. Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/