Re: [Libguestfs] [PATCH libnbd v2 2/4] common/include: Copy ascii-ctype functions from nbdkit

On 1/30/23 23:55, Richard W.M. Jones wrote:

--- .gitignore | 1 + common/include/Makefile.am | 6 +++ common/include/ascii-ctype.h | 75 ++++++++++++++++++++++++++ common/include/test-ascii-ctype.c | 88 +++++++++++++++++++++++++++++++ 4 files changed, 170 insertions(+)

I suggest noting in the commit message the commit hash of nbdkit at which the files are taken. Reviewed-by: Laszlo Ersek <lersek@redhat.com>