On 01/18/22 14:48, Laszlo Ersek wrote:
The 2nd patch in the series says it all; the first patch is just a typo fix that I felt should be split off.
Thanks Laszlo
Laszlo Ersek (2): server/sockets: supply trailing newline for gai_strerror() format string server/sockets: get rid of AI_ADDRCONFIG
common/utils/windows-compat.h | 7 ------- docs/nbdkit.pod | 20 +++++++++++++++++++- docs/synopsis.txt | 3 ++- server/internal.h | 1 + server/main.c | 9 +++++++++ server/options.h | 4 +++- server/sockets.c | 5 +++-- 7 files changed, 37 insertions(+), 12 deletions(-)
base-commit: 726f7f30aad14169ef878e579d9333670b5df2fa
Pushed as commit range 4df525566b38..9eec2335d630, with the following updates:
1: ee130762f9e5 ! 1: 85b653d43cac server/sockets: supply trailing newline for gai_strerror() format string @@ -2,7 +2,11 @@
server/sockets: supply trailing newline for gai_strerror() format string
+ Fixes: 999797bad ("Implement nbdkit server.", v0.1.0) Signed-off-by: Laszlo Ersek <lersek@redhat.com> + Message-Id: <20220118134833.13246-2-lersek@redhat.com> + [lersek@redhat.com: add "Fixes:" line (Eric)] + Acked-by: Eric Blake <eblake@redhat.com>
diff --git a/server/sockets.c b/server/sockets.c --- a/server/sockets.c 2: 499377c22999 ! 2: 9eec2335d630 server/sockets: get rid of AI_ADDRCONFIG @@ -9,7 +9,7 @@ The main problem with AI_ADDRCONFIG can be shown with the following command line:
- $ nbdkit -f -p 32776 -P pidfile -i ::1 -exit-with-parent null + $ nbdkit -f -p 32776 -P pidfile -i ::1 --exit-with-parent null
On a host where ::1 is the only IPv6 address assigned (namely to the loopback interface), the command fails with @@ -48,6 +48,9 @@
Ref: https://listman.redhat.com/archives/libguestfs/2022-January/msg00110.html Signed-off-by: Laszlo Ersek <lersek@redhat.com> + Message-Id: <20220118134833.13246-3-lersek@redhat.com> + [lersek@redhat.com: fix typo in "--exit-with-parent" (Eric)] + Acked-by: Eric Blake <eblake@redhat.com>
diff --git a/docs/nbdkit.pod b/docs/nbdkit.pod --- a/docs/nbdkit.pod
Thanks! Laszlo