[PATCH] run-*-locally: The programs are now virt-[tool], not virt-[tool].pl
All the run-*-locally scripts were broken ... Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v
Richard W.M. Jones wrote:
All the run-*-locally scripts were broken ... Subject: [PATCH 2/2] run-*-locally: The programs are now virt-[tool], not virt-[tool].pl
This fixes commit b488436cc54288fcae8988493749f2e6c87f274c. --- cat/run-cat-locally | 2 +- df/run-df-locally | 2 +- edit/run-edit-locally | 2 +- inspector/run-inspector-locally | 2 +- rescue/run-rescue-locally | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/cat/run-cat-locally b/cat/run-cat-locally index be60d07..7c31aaf 100755 --- a/cat/run-cat-locally +++ b/cat/run-cat-locally @@ -49,4 +49,4 @@ $ENV{LD_LIBRARY_PATH} = $path.'/src/.libs'; $ENV{LIBGUESTFS_PATH} = $path.'/appliance'; $ENV{PERL5LIB} = $path.'/perl/blib/lib:'.$path.'/perl/blib/arch';
-exec('perl', $path.'/cat/virt-cat.pl', @ARGV); +exec('perl', $path.'/cat/virt-cat', @ARGV);
ACK. Was this provoking failed tests? If not, would it be easy to add one or two?
On Thu, Oct 01, 2009 at 05:27:40PM +0200, Jim Meyering wrote:
Richard W.M. Jones wrote:
All the run-*-locally scripts were broken ... Subject: [PATCH 2/2] run-*-locally: The programs are now virt-[tool], not virt-[tool].pl
This fixes commit b488436cc54288fcae8988493749f2e6c87f274c. --- cat/run-cat-locally | 2 +- df/run-df-locally | 2 +- edit/run-edit-locally | 2 +- inspector/run-inspector-locally | 2 +- rescue/run-rescue-locally | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/cat/run-cat-locally b/cat/run-cat-locally index be60d07..7c31aaf 100755 --- a/cat/run-cat-locally +++ b/cat/run-cat-locally @@ -49,4 +49,4 @@ $ENV{LD_LIBRARY_PATH} = $path.'/src/.libs'; $ENV{LIBGUESTFS_PATH} = $path.'/appliance'; $ENV{PERL5LIB} = $path.'/perl/blib/lib:'.$path.'/perl/blib/arch';
-exec('perl', $path.'/cat/virt-cat.pl', @ARGV); +exec('perl', $path.'/cat/virt-cat', @ARGV);
ACK. Was this provoking failed tests? If not, would it be easy to add one or two?
Tricky ... Of the programs (virt-df, virt-cat, virt-edit, virt-rescue, virt-inspector), at least two really need a full [Linux] distribution image in order to test them, so at the moment we don't test any of them. These are only for libguestfs developers, so the errors would never have been seen except by someone who was literally trying to debug these programs in the source (as I was). Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 75 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
participants (2)
-
Jim Meyering -
Richard W.M. Jones