[PATCH] builder: remove unused variables
Leftovers of the list_entries_short+list_entries_long split done in 91aae893c70b3877b31803800ba77836fd7a45e8. --- builder/list_entries.ml | 3 --- 1 file changed, 3 deletions(-) diff --git a/builder/list_entries.ml b/builder/list_entries.ml index 2f47231..80a309d 100644 --- a/builder/list_entries.ml +++ b/builder/list_entries.ml @@ -47,9 +47,6 @@ let rec list_entries ~list_format ~sources index = and list_entries_short index = List.iter ( fun (name, { Index_parser.printable_name = printable_name; - size = size; - compressed_size = compressed_size; - notes = notes; hidden = hidden }) -> if not hidden then ( printf "%-24s" name; -- 1.8.3.1
On Thu, Jan 30, 2014 at 02:44:13PM +0100, Pino Toscano wrote:
Leftovers of the list_entries_short+list_entries_long split done in 91aae893c70b3877b31803800ba77836fd7a45e8.
I think you have to write the word "commit " before the hash, so that various tools like github know it's a commit hash. (Actually, I've always assumed this, but not tested it). ACK. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org
On Thursday 30 January 2014 15:53:10 Richard W.M. Jones wrote:
On Thu, Jan 30, 2014 at 02:44:13PM +0100, Pino Toscano wrote:
Leftovers of the list_entries_short+list_entries_long split done in 91aae893c70b3877b31803800ba77836fd7a45e8.
I think you have to write the word "commit " before the hash, so that various tools like github know it's a commit hash. (Actually, I've always assumed this, but not tested it).
I've seen different degrees in supporting this by different tools, i.e. some of them able to link to commits just with the hash, while others needing the "commit " prefix. In any case, adding the prefix to make both happy is straightforward enough.
ACK.
Commit text amended and pushed, thanks. -- Pino Toscano
participants (2)
-
Pino Toscano -
Richard W.M. Jones