A few basics first: - The commit doesn't have an author name. : Fixed - The commit has no information at all about the change. : Fixed - One file at least has whitespace problems, adding empty lines at the end of the file. : Fixed - There are no tests at all. : In progress. - Copyright dates are not 2024. : Fixed. - Make the first line of the top comment be about the file, not just something that was copied and pasted.: Please point out which file. And let's think about how to split up the commits to make a story: ________________________________ From: Richard W.M. Jones <rjones@redhat.com> Sent: Monday, July 1, 2024 2:33 PM To: Ravi Singh <Ravi.Singh@veritas.com> Cc: guestfs@lists.libguestfs.org <guestfs@lists.libguestfs.org>; Aswad Kulkarni <aswad.kulkarni@veritas.com>; Shailesh Marathe <Shailesh.Marathe@veritas.com>; Sumit Dighe <Sumit.Dighe@veritas.com>; Brad Boyer <brad.boyer@veritas.com>; Saket Pusalkar <Saket.Pusalkar@veritas.com>; Gaurang Agnihotri <Gaurang.Agnihotri@veritas.com>; Mitul Kothari <Mitul.Kothari@veritas.com>; Satyajit Gorhe parlikar <Satyajit.Gorheparlik@veritas.com>; John Cronin <john.cronin@veritas.com> Subject: Re: [External] Re: [Libguestfs] [PATCH] VxFS Filesystem support to libguestfs CAUTION: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. If you believe this is a phishing email, use the Report to Cybersecurity icon in Outlook. On Mon, Jul 01, 2024 at 06:56:40AM +0000, Ravi Singh wrote:

Hi Richard,

As discussed, I have created a fork from the master branch and updated it with my patch. Here are the details of the testing I conducted:

1. Ran `make quickcheck`: Please find the attached log file for the results. 2. Ran `make check`: A few tests are failing on my system due to issues with Fedora and SQLite configurations. The log file for this test is also attached.

You can find the forked branch at the following link: https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frsingh-veritas%2Flibguestfs.git&data=05%7C02%7Cravi.singh%40veritas.com%7C1a50ce88cdec4be3b8db08dc99acbfc5%7Cfc8e13c0422c4c55b3eaca318e6cac32%7C0%7C0%7C638554214453716875%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=vgnxbN3E2AodPgxhj9E5XwZGmfE4QxCCAPIbcMSA9wU%3D&reserved=0<https://github.com/rsingh-veritas/libguestfs.git>

A few basics first: - The commit doesn't have an author name. - The commit has no information at all about the change. - One file at least has whitespace problems, adding empty lines at the end of the file. - There are no tests at all. - Copyright dates are not 2024. - Make the first line of the top comment be about the file, not just something that was copied and pasted. And let's think about how to split up the commits to make a story: https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpeople.redhat.com%2Frjones%2Fhow-to-supply-code-to-open-source-projects%2F&data=05%7C02%7Cravi.singh%40veritas.com%7C1a50ce88cdec4be3b8db08dc99acbfc5%7Cfc8e13c0422c4c55b3eaca318e6cac32%7C0%7C0%7C638554214453727720%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=nAIn4ZzAvwkJCtRIZj2v423gUVqXFQzq8XsrETLihXM%3D&reserved=0<https://people.redhat.com/rjones/how-to-supply-code-to-open-source-projects/> (section 3) Rich. -- Richard Jones, Virtualization Group, Red Hat https://nam12.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpeople.redhat.com%2F~rjones&data=05%7C02%7Cravi.singh%40veritas.com%7C1a50ce88cdec4be3b8db08dc99acbfc5%7Cfc8e13c0422c4c55b3eaca318e6cac32%7C0%7C0%7C638554214453735451%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=IcggKIzj1TvBKEslTtJ1Dr1HKXUVDm9HvezwVvRaXMY%3D&reserved=0<http://people.redhat.com/~rjones> Read my programming and virtualization blog: https://nam12.safelinks.protection.outlook.com/?url=http%3A%2F%2Frwmj.wordpress.com%2F&data=05%7C02%7Cravi.singh%40veritas.com%7C1a50ce88cdec4be3b8db08dc99acbfc5%7Cfc8e13c0422c4c55b3eaca318e6cac32%7C0%7C0%7C638554214453740233%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=GPq%2B6IkGT7lKm8Lhnb%2BOybeDBIzRWhvhqcDFV2jNYu8%3D&reserved=0<http://rwmj.wordpress.com/> virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. https://nam12.safelinks.protection.outlook.com/?url=http%3A%2F%2Flibguestfs.org%2Fvirt-v2v&data=05%7C02%7Cravi.singh%40veritas.com%7C1a50ce88cdec4be3b8db08dc99acbfc5%7Cfc8e13c0422c4c55b3eaca318e6cac32%7C0%7C0%7C638554214453744871%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=uZq9rUGK01YKTycsA%2F5wVFQpRt8%2FqLNXu5i6SY8brz0%3D&reserved=0<http://libguestfs.org/virt-v2v>