[PATCH 0/4] Fix RHBZ#597112 (get-e2uuid command)
This series of patches fixes: https://bugzilla.redhat.com/show_bug.cgi?id=597112 -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v
On 01/06/10 15:36, Richard W.M. Jones wrote:
From 85c71f8fff3e80f549342bf995b686ba7303c2b4 Mon Sep 17 00:00:00 2001 From: Richard Jones<rjones@redhat.com> Date: Tue, 1 Jun 2010 13:39:25 +0100 Subject: [PATCH 1/4] daemon: Generalize the implementation of vfs-type.
Note that there is no change to the semantics of the code. --- daemon/blkid.c | 12 +++++++++--- 1 files changed, 9 insertions(+), 3 deletions(-)
ACK. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones New in Fedora 11: Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 70 libraries supprt'd http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw
On 01/06/10 15:37, Richard W.M. Jones wrote:
From 21c42e9fabf6cea3d564e338a314479ef120502a Mon Sep 17 00:00:00 2001 From: Richard Jones<rjones@redhat.com> Date: Tue, 1 Jun 2010 15:27:57 +0100 Subject: [PATCH 2/4] daemon: Kill blkid cache to improve reliability of blkid commands.
By killing the cache file, we make blkid work in situations such as a just-created filesystem. --- daemon/blkid.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)
This is always safe as far as I'm aware. ACK. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top
On 01/06/10 15:37, Richard W.M. Jones wrote:
From 27b730a6820b80a49a4da1af9f4c8e8a952f735e Mon Sep 17 00:00:00 2001 From: Richard Jones<rjones@redhat.com> Date: Tue, 1 Jun 2010 13:57:12 +0100 Subject: [PATCH 3/4] New APIs: vfs-label and vfs-uuid return label and uuid for many fs types.
These APIs generalize the existing 'get-e2label' and 'get-e2uuid' calls, to provide calls which should be able to get the label and UUID for most filesystem types. These use 'blkid' to do the work.
I have tested that the blkid commands themselves work on RHEL 5.
(Suggested by Yufang Zhang). --- daemon/blkid.c | 12 ++++++++++++ src/MAX_PROC_NR | 2 +- src/generator.ml | 23 +++++++++++++++++++++++ 3 files changed, 36 insertions(+), 1 deletions(-)
ACK. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://et.redhat.com/~rjones/virt-df/
On 01/06/10 15:38, Richard W.M. Jones wrote:
From da4812ab6b44c29cb3cf181c7aa896420ecb8aa6 Mon Sep 17 00:00:00 2001 From: Richard Jones<rjones@redhat.com> Date: Tue, 1 Jun 2010 14:04:51 +0100 Subject: [PATCH 4/4] Fix and deprecate get_e2label and get_e2uuid (RHBZ#597112).
Fix these calls (see description in RHBZ#597112), but also deprecate them since the new calls vfs_label and vfs_uuid can work on any filesystem type.
This also adds a regression test for the original bug reported in RHBZ#597112. --- daemon/ext2.c | 84 +---------------------------------------------------- src/generator.ml | 11 +++++-- 2 files changed, 10 insertions(+), 85 deletions(-)
Excellent code shrinkage :) ACK. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490
participants (2)
-
Matthew Booth -
Richard W.M. Jones