Building libguestfs from git
Looks like libguestfs build is broken, or not documented properly. I tried (based on http://libguestfs.org/guestfs-building.1.html): git clean -dxf ./autogen.sh autoreconf failes with: autoreconf: running: automake --add-missing --copy --no-force configure.ac:38: installing 'build-aux/missing' configure.ac:221: error: required file 'common/mlcustomize/Makefile.in' not found configure.ac:221: error: required file 'common/mllibvirt/Makefile.in' not found configure.ac:221: error: required file 'common/mlstdutils/guestfs_config.ml.in' not found configure.ac:221: error: required file 'common/mlv2v/Makefile.in' not found Makefile.am:161: error: required directory ./common/mlcustomize does not exist Makefile.am:161: error: required directory ./common/mlv2v does not exist Makefile.am:169: error: required directory ./common/mllibvirt does not exist parallel-tests: installing 'build-aux/test-driver' align/Makefile.am: installing 'build-aux/depcomp' configure.ac: installing 'build-aux/ylwrap' autoreconf: automake failed with exit status: 1 But the autogen.sh continue, ignoring the failure... Finally it fails with: config.status: error: cannot find input file: `Makefile.in' I tried to run it again: ./autogen.sh the autoreconf errors show again, but this time it succeeds, but: $ make -j8 cfg.mk:139: *** gnulib update required; run ./autogen.sh first. Stop. Running ./autoge.sh again does not help. I can build tag v1.40.2, but it is missing some patches in virt-v2v that I need. Thanks, Nir
On Sun, Nov 17, 2019 at 6:22 PM Nir Soffer <nsoffer@redhat.com> wrote:
Looks like libguestfs build is broken, or not documented properly.
I tried (based on http://libguestfs.org/guestfs-building.1.html):
git clean -dxf ./autogen.sh
autoreconf failes with:
autoreconf: running: automake --add-missing --copy --no-force configure.ac:38: installing 'build-aux/missing' configure.ac:221: error: required file 'common/mlcustomize/Makefile.in' not found configure.ac:221: error: required file 'common/mllibvirt/Makefile.in' not found configure.ac:221: error: required file 'common/mlstdutils/guestfs_config.ml.in' not found configure.ac:221: error: required file 'common/mlv2v/Makefile.in' not found Makefile.am:161: error: required directory ./common/mlcustomize does not exist Makefile.am:161: error: required directory ./common/mlv2v does not exist Makefile.am:169: error: required directory ./common/mllibvirt does not exist parallel-tests: installing 'build-aux/test-driver' align/Makefile.am: installing 'build-aux/depcomp' configure.ac: installing 'build-aux/ylwrap' autoreconf: automake failed with exit status: 1
But the autogen.sh continue, ignoring the failure...
Finally it fails with:
config.status: error: cannot find input file: `Makefile.in'
I tried to run it again:
./autogen.sh
the autoreconf errors show again, but this time it succeeds, but:
$ make -j8 cfg.mk:139: *** gnulib update required; run ./autogen.sh first. Stop.
Running ./autoge.sh again does not help.
I can build tag v1.40.2, but it is missing some patches in virt-v2v that I need.
I found that v1.40.5 has all the patches I need, and I can build it on Fedora 30, so I have a workaround for now.
Thanks, Nir
On Sun, Nov 17, 2019 at 06:22:20PM +0200, Nir Soffer wrote:
Looks like libguestfs build is broken, or not documented properly.
I tried (based on http://libguestfs.org/guestfs-building.1.html):
Quite possibly, it's early days. One thing you will definitely need to do is: git submodule init git submodule update Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html
On Sun, Nov 17, 2019 at 7:05 PM Richard W.M. Jones <rjones@redhat.com> wrote:
On Sun, Nov 17, 2019 at 06:22:20PM +0200, Nir Soffer wrote:
Looks like libguestfs build is broken, or not documented properly.
I tried (based on http://libguestfs.org/guestfs-building.1.html):
Quite possibly, it's early days. One thing you will definitely need to do is:
git submodule init git submodule update
I think I tried this based on your comment from last week, but it did not help. I will try it again with a clean checkout.
On Sun, Nov 17, 2019 at 07:11:05PM +0200, Nir Soffer wrote:
On Sun, Nov 17, 2019 at 7:05 PM Richard W.M. Jones <rjones@redhat.com> wrote:
On Sun, Nov 17, 2019 at 06:22:20PM +0200, Nir Soffer wrote:
Looks like libguestfs build is broken, or not documented properly.
I tried (based on http://libguestfs.org/guestfs-building.1.html):
Quite possibly, it's early days. One thing you will definitely need to do is:
git submodule init git submodule update
I think I tried this based on your comment from last week, but it did not help.
I will try it again with a clean checkout.
The common/ subdirectory is a git submodule (see .gitmodules). No one likes git submodules very much, or at least they take a bit of getting used to :-/ But any information you can find online about git submodules should be relevant. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW
On 11/17/19 11:04 AM, Richard W.M. Jones wrote:
On Sun, Nov 17, 2019 at 06:22:20PM +0200, Nir Soffer wrote:
Looks like libguestfs build is broken, or not documented properly.
I tried (based on http://libguestfs.org/guestfs-building.1.html):
Quite possibly, it's early days. One thing you will definitely need to do is:
git submodule init git submodule update
Should ./autogen.sh take on this role automatically? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
On Mon, Nov 18, 2019 at 01:47:18PM -0600, Eric Blake wrote:
On 11/17/19 11:04 AM, Richard W.M. Jones wrote:
On Sun, Nov 17, 2019 at 06:22:20PM +0200, Nir Soffer wrote:
Looks like libguestfs build is broken, or not documented properly.
I tried (based on http://libguestfs.org/guestfs-building.1.html):
Quite possibly, it's early days. One thing you will definitely need to do is:
git submodule init git submodule update
Should ./autogen.sh take on this role automatically?
Probably, although I'm not quite sure how ./autogen.sh comes about. Is it an arbitrary script that every project rewrites? How is it related to ./bootstrap? Looking at git history, it seems I added a trivial version which just did autoreconf back in 2009, and most of the work was done on it early on by Jim Meyering. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW
On 11/19/19 2:24 AM, Richard W.M. Jones wrote:
On Mon, Nov 18, 2019 at 01:47:18PM -0600, Eric Blake wrote:
On 11/17/19 11:04 AM, Richard W.M. Jones wrote:
On Sun, Nov 17, 2019 at 06:22:20PM +0200, Nir Soffer wrote:
Looks like libguestfs build is broken, or not documented properly.
I tried (based on http://libguestfs.org/guestfs-building.1.html):
Quite possibly, it's early days. One thing you will definitely need to do is:
git submodule init git submodule update
Should ./autogen.sh take on this role automatically?
Probably, although I'm not quite sure how ./autogen.sh comes about. Is it an arbitrary script that every project rewrites? How is it related to ./bootstrap?
./autogen.sh and ./bootstrap are the two most common names for said script (I prefer bootstrap, as there is an actual project named Autogen that is unrelated to what autogen.sh typically does). And yes, it tends to be something that each project writes: neither Autoconf nor Automake provide the script. I'm not aware of any place that purports to provide a commonly reusable ./autogen.sh; gnulib does provide a somewhat-reusable ./bootstrap (which may work for libguestfs as it uses gnulib, but won't work for things like nbdkit that can't use gnulib). So we get to tweak it however we want, and copy-and-paste things that work from one place to another.
Looking at git history, it seems I added a trivial version which just did autoreconf back in 2009, and most of the work was done on it early on by Jim Meyering.
Rich.
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
participants (3)
-
Eric Blake -
Nir Soffer -
Richard W.M. Jones