Re: [Libguestfs] libnbd | Failed pipeline for master | 70da51e5
Hi Martin, On Thu, Sep 02, 2021 at 04:05:56PM +0000, GitLab wrote:
GitLab ✖ Pipeline #364204388 has failed!
Project nbdkit / libnbd Branch ● master Commit ● 70da51e5 interop: Link interop-nbd-server-tls with -lgnu... Commit Author ● Richard W.M. Jones
Pipeline #364204388 triggered by ● Richard W.M. Jones had 1 failed job. Failed jobs ✖ builds x64-opensuse-tumbleweed GitLab
This is failing on a new test I added, but it's failing because of how a particular package is built in OpenSUSE. The new test is: https://gitlab.com/nbdkit/libnbd/-/commit/c833fa1226092fd51b1211fa195a2a3b79... which tries to test libnbd client with TLS enabled against nbd-server. nbd-server in OpenSUSE gives this error: Error: inetd mode requires syslog Exiting. which means it was compiled without --enable-syslog. I notice that the related test is skipped: SKIP: interop-nbd-server ======================== Test skipped based on ci/skipped_tests file SKIP interop-nbd-server (exit status: 77) The format of ci/skipped_tests is pretty odd. Is this patch OK? diff --git a/ci/skipped_tests b/ci/skipped_tests index e2de9330..c494b9eb 100644 --- a/ci/skipped_tests +++ b/ci/skipped_tests @@ -1,9 +1,9 @@ # Old nbd-server and built without syslog support, tests deadlock, old qemu-img version -^Ubuntu-18\.04$;interop/interop-nbd-server interop/list-exports-nbd-server interop/structured-read.sh -^openSUSE Leap-15;interop/interop-nbd-server interop/list-exports-nbd-server +^Ubuntu-18\.04$;interop/interop-nbd-server interop/interop-nbd-server-tls interop/list-exports-nbd-server interop/structured-read.sh +^openSUSE Leap-15;interop/interop-nbd-server interop/interop-nbd-server-tls interop/list-exports-nbd-server # Similar for Tumbleweed, except tests do not deadlock, only limit to version 2021* for now -^openSUSE Tumbleweed-2021;interop/interop-nbd-server interop/list-exports-nbd-server +^openSUSE Tumbleweed-2021;interop/interop-nbd-server interop/interop-nbd-server-tls interop/list-exports-nbd-server # Debian 10 has weird golang issues (old golang anyway) and old qemu-img ^Debian GNU/Linux-10;golang/run-tests.sh interop/structured-read.sh Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top
On Thu, Sep 02, 2021 at 05:12:35PM +0100, Richard W.M. Jones wrote:
Hi Martin,
On Thu, Sep 02, 2021 at 04:05:56PM +0000, GitLab wrote:
GitLab ✖ Pipeline #364204388 has failed!
Project nbdkit / libnbd Branch ● master Commit ● 70da51e5 interop: Link interop-nbd-server-tls with -lgnu... Commit Author ● Richard W.M. Jones
Pipeline #364204388 triggered by ● Richard W.M. Jones had 1 failed job. Failed jobs ✖ builds x64-opensuse-tumbleweed GitLab
This is failing on a new test I added, but it's failing because of how a particular package is built in OpenSUSE.
The new test is:
https://gitlab.com/nbdkit/libnbd/-/commit/c833fa1226092fd51b1211fa195a2a3b79...
which tries to test libnbd client with TLS enabled against nbd-server. nbd-server in OpenSUSE gives this error:
Error: inetd mode requires syslog Exiting.
which means it was compiled without --enable-syslog.
I notice that the related test is skipped:
SKIP: interop-nbd-server ========================
Test skipped based on ci/skipped_tests file SKIP interop-nbd-server (exit status: 77)
The format of ci/skipped_tests is pretty odd. Is this patch OK?
Yes, I know, feel free to suggest anything better. The patch is ok.
diff --git a/ci/skipped_tests b/ci/skipped_tests index e2de9330..c494b9eb 100644 --- a/ci/skipped_tests +++ b/ci/skipped_tests @@ -1,9 +1,9 @@ # Old nbd-server and built without syslog support, tests deadlock, old qemu-img version -^Ubuntu-18\.04$;interop/interop-nbd-server interop/list-exports-nbd-server interop/structured-read.sh -^openSUSE Leap-15;interop/interop-nbd-server interop/list-exports-nbd-server +^Ubuntu-18\.04$;interop/interop-nbd-server interop/interop-nbd-server-tls interop/list-exports-nbd-server interop/structured-read.sh +^openSUSE Leap-15;interop/interop-nbd-server interop/interop-nbd-server-tls interop/list-exports-nbd-server
# Similar for Tumbleweed, except tests do not deadlock, only limit to version 2021* for now -^openSUSE Tumbleweed-2021;interop/interop-nbd-server interop/list-exports-nbd-server +^openSUSE Tumbleweed-2021;interop/interop-nbd-server interop/interop-nbd-server-tls interop/list-exports-nbd-server
# Debian 10 has weird golang issues (old golang anyway) and old qemu-img ^Debian GNU/Linux-10;golang/run-tests.sh interop/structured-read.sh
ACK
Rich.
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top
On Thu, Sep 02, 2021 at 05:12:35PM +0100, Richard W.M. Jones wrote:
Hi Martin,
On Thu, Sep 02, 2021 at 04:05:56PM +0000, GitLab wrote:
GitLab ✖ Pipeline #364204388 has failed!
Project nbdkit / libnbd Branch ● master Commit ● 70da51e5 interop: Link interop-nbd-server-tls with -lgnu... Commit Author ● Richard W.M. Jones
Pipeline #364204388 triggered by ● Richard W.M. Jones had 1 failed job. Failed jobs ✖ builds x64-opensuse-tumbleweed GitLab
This is failing on a new test I added, but it's failing because of how a particular package is built in OpenSUSE.
The new test is:
https://gitlab.com/nbdkit/libnbd/-/commit/c833fa1226092fd51b1211fa195a2a3b79...
which tries to test libnbd client with TLS enabled against nbd-server. nbd-server in OpenSUSE gives this error:
Error: inetd mode requires syslog Exiting.
which means it was compiled without --enable-syslog.
Hi Martin, this test is failing again: https://gitlab.com/nbdkit/libnbd/-/jobs/1939810938 The error is the same as before: Error: inetd mode requires syslog I guess this is something to do with the new year (see patch below)? We could hack around this again, but I wonder if we could actually fix this properly somehow. Either get OpenSUSE to use --enable-syslog, or somehow try to detect if the binary is not using syslog. Rich.
I notice that the related test is skipped:
SKIP: interop-nbd-server ========================
Test skipped based on ci/skipped_tests file SKIP interop-nbd-server (exit status: 77)
The format of ci/skipped_tests is pretty odd. Is this patch OK?
diff --git a/ci/skipped_tests b/ci/skipped_tests index e2de9330..c494b9eb 100644 --- a/ci/skipped_tests +++ b/ci/skipped_tests @@ -1,9 +1,9 @@ # Old nbd-server and built without syslog support, tests deadlock, old qemu-img version -^Ubuntu-18\.04$;interop/interop-nbd-server interop/list-exports-nbd-server interop/structured-read.sh -^openSUSE Leap-15;interop/interop-nbd-server interop/list-exports-nbd-server +^Ubuntu-18\.04$;interop/interop-nbd-server interop/interop-nbd-server-tls interop/list-exports-nbd-server interop/structured-read.sh +^openSUSE Leap-15;interop/interop-nbd-server interop/interop-nbd-server-tls interop/list-exports-nbd-server
# Similar for Tumbleweed, except tests do not deadlock, only limit to version 2021* for now -^openSUSE Tumbleweed-2021;interop/interop-nbd-server interop/list-exports-nbd-server +^openSUSE Tumbleweed-2021;interop/interop-nbd-server interop/interop-nbd-server-tls interop/list-exports-nbd-server
# Debian 10 has weird golang issues (old golang anyway) and old qemu-img ^Debian GNU/Linux-10;golang/run-tests.sh interop/structured-read.sh
Rich.
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top
_______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html
On Tue, Jan 04, 2022 at 01:56:08PM +0000, Richard W.M. Jones wrote:
On Thu, Sep 02, 2021 at 05:12:35PM +0100, Richard W.M. Jones wrote:
Hi Martin,
On Thu, Sep 02, 2021 at 04:05:56PM +0000, GitLab wrote:
GitLab ✖ Pipeline #364204388 has failed!
Project nbdkit / libnbd Branch ● master Commit ● 70da51e5 interop: Link interop-nbd-server-tls with -lgnu... Commit Author ● Richard W.M. Jones
Pipeline #364204388 triggered by ● Richard W.M. Jones had 1 failed job. Failed jobs ✖ builds x64-opensuse-tumbleweed GitLab
This is failing on a new test I added, but it's failing because of how a particular package is built in OpenSUSE.
The new test is:
https://gitlab.com/nbdkit/libnbd/-/commit/c833fa1226092fd51b1211fa195a2a3b79...
which tries to test libnbd client with TLS enabled against nbd-server. nbd-server in OpenSUSE gives this error:
Error: inetd mode requires syslog Exiting.
which means it was compiled without --enable-syslog.
Hi Martin, this test is failing again:
https://gitlab.com/nbdkit/libnbd/-/jobs/1939810938
The error is the same as before:
Error: inetd mode requires syslog
I guess this is something to do with the new year (see patch below)? We could hack around this again, but I wonder if we could actually fix this properly somehow. Either get OpenSUSE to use --enable-syslog, or
Could be, but: a) my guess is that they do it deliberately b) there might be another distro in the future that we want to support which will have the same issue
somehow try to detect if the binary is not using syslog.
I tried various ways and I can't think of anything else than just trying to run something that will fail like this and then skip the test if it failed.
Rich.
I notice that the related test is skipped:
SKIP: interop-nbd-server ========================
Test skipped based on ci/skipped_tests file SKIP interop-nbd-server (exit status: 77)
The format of ci/skipped_tests is pretty odd. Is this patch OK?
diff --git a/ci/skipped_tests b/ci/skipped_tests index e2de9330..c494b9eb 100644 --- a/ci/skipped_tests +++ b/ci/skipped_tests @@ -1,9 +1,9 @@ # Old nbd-server and built without syslog support, tests deadlock, old qemu-img version -^Ubuntu-18\.04$;interop/interop-nbd-server interop/list-exports-nbd-server interop/structured-read.sh -^openSUSE Leap-15;interop/interop-nbd-server interop/list-exports-nbd-server +^Ubuntu-18\.04$;interop/interop-nbd-server interop/interop-nbd-server-tls interop/list-exports-nbd-server interop/structured-read.sh +^openSUSE Leap-15;interop/interop-nbd-server interop/interop-nbd-server-tls interop/list-exports-nbd-server
# Similar for Tumbleweed, except tests do not deadlock, only limit to version 2021* for now -^openSUSE Tumbleweed-2021;interop/interop-nbd-server interop/list-exports-nbd-server +^openSUSE Tumbleweed-2021;interop/interop-nbd-server interop/interop-nbd-server-tls interop/list-exports-nbd-server
# Debian 10 has weird golang issues (old golang anyway) and old qemu-img ^Debian GNU/Linux-10;golang/run-tests.sh interop/structured-read.sh
Rich.
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top
_______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html
On Tue, Jan 04, 2022 at 03:34:53PM +0100, Martin Kletzander wrote:
On Tue, Jan 04, 2022 at 01:56:08PM +0000, Richard W.M. Jones wrote:
somehow try to detect if the binary is not using syslog.
I tried various ways and I can't think of anything else than just trying to run something that will fail like this and then skip the test if it failed.
OK let's try this then ... $ nbd-server -d -C /dev/null 0 /dev/null </dev/null 2>&1 >/dev/null | grep -sq "Error: inetd mode requires syslog" This command will exit with 0 if the binary doesn't support syslog and with 1 if the binary does support syslog (grep -v to reverse this). I'll see if I can come up with a patch. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html
I created a merge request on the theory that this will run the CI pipeline, thus testing my patch on OpenSUSE ... https://gitlab.com/nbdkit/libnbd/-/merge_requests/2 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html
On Tue, Jan 04, 2022 at 03:55:08PM +0000, Richard W.M. Jones wrote:
I created a merge request on the theory that this will run the CI pipeline, thus testing my patch on OpenSUSE ...
It did, OpenSUSE is fine, Ubuntu 18.04 deadlocks because you removed the skip for the interop-nbd-server. I know that I wrote the comments in the file pretty badly, but it was PITA to find all that out and I did not have enough energy to go back and comment properly on every skipped test, especially with something as old as ubuntu 18.04.
Rich.
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html
_______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
On Tue, Jan 04, 2022 at 09:35:18PM +0100, Martin Kletzander wrote:
On Tue, Jan 04, 2022 at 03:55:08PM +0000, Richard W.M. Jones wrote:
I created a merge request on the theory that this will run the CI pipeline, thus testing my patch on OpenSUSE ...
It did, OpenSUSE is fine, Ubuntu 18.04 deadlocks because you removed the skip for the interop-nbd-server. I know that I wrote the comments in the file pretty badly, but it was PITA to find all that out and I did not have enough energy to go back and comment properly on every skipped test, especially with something as old as ubuntu 18.04.
Do you recall what exactly was the problem with 18.04? I've been trying off and on to debug that failure. It's not with the change I made but with something else. Annoyingly gitlab does not preserve artifacts when a job times out (https://gitlab.com/gitlab-org/gitlab/-/issues/19818) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html
On Tue, Jan 04, 2022 at 08:42:14PM +0000, Richard W.M. Jones wrote:
On Tue, Jan 04, 2022 at 09:35:18PM +0100, Martin Kletzander wrote:
On Tue, Jan 04, 2022 at 03:55:08PM +0000, Richard W.M. Jones wrote:
I created a merge request on the theory that this will run the CI pipeline, thus testing my patch on OpenSUSE ...
It did, OpenSUSE is fine, Ubuntu 18.04 deadlocks because you removed the skip for the interop-nbd-server. I know that I wrote the comments in the file pretty badly, but it was PITA to find all that out and I did not have enough energy to go back and comment properly on every skipped test, especially with something as old as ubuntu 18.04.
Do you recall what exactly was the problem with 18.04? I've been trying off and on to debug that failure. It's not with the change I made but with something else. Annoyingly gitlab does not preserve artifacts when a job times out (https://gitlab.com/gitlab-org/gitlab/-/issues/19818)
Well, I was able to reproduce it locally with podman. But all I remember was in the comments. It was so tedious and it took so long to make sure I am not skipping any test unless I found no other way. It's all mixed up in my head.
Rich.
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html
participants (2)
-
Martin Kletzander -
Richard W.M. Jones