On Fri, Dec 07, 2018 at 09:09:02PM +0200, Nir Soffer wrote:
On Fri, Dec 7, 2018 at 8:50 PM Richard W.M. Jones <rjones@redhat.com> wrote:
On Fri, Dec 07, 2018 at 07:55:28PM +0200, Nir Soffer wrote:
Replace python 2 only "buffer" with "memoryview".
Falling back to emulated zero would fail with:
NameError: name 'buffer' is not defined
I did not test the changed code but it was not tested before so it is unlikely to be worse.
Detected by pylint.
Thanks - I pushed both.
I wonder how the pread method worked before? That's on the main path I think.
I never seen a READ request on imageio log, so it seems that qemu-img convert never read from the destination.
Yeah of course, _reading_, I forgot we don't do that :-) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/