Re: [Libguestfs] [PATCH v2] mlcustomize: Trim whitespaces from commands read from file (RHBZ#1351000)

On Wednesday, 29 January 2020 17:22:51 CET Richard W.M. Jones wrote: > On Wed, Jan 29, 2020 at 03:07:12PM +0100, Martin Kletzander wrote: > > From: Martin Kletzander <mkletzan(a)redhat.com&gt; > > > > The first split does not care about the whole string, it is just trying to get > > the command name in front, so triml is just right. > > > > Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com&gt; > > --- > > mlcustomize/customize_cmdline.ml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/mlcustomize/customize_cmdline.ml b/mlcustomize/customize_cmdline.ml > > index c062379879e2..abd21a4cbca5 100644 > > --- a/mlcustomize/customize_cmdline.ml > > +++ b/mlcustomize/customize_cmdline.ml > > @@ -481,6 +481,7 @@ let rec argspec () = > > ] in > > let lines = read_whole_file filename in > > let lines = String.lines_split lines in > > + let lines = List.map String.triml lines in > > let lines = List.filter ( > > fun line -> > > String.length line > 0 && line.[0] <> '#' > > Seems OK to me, so ACK. LGTM as well, so pushed: https://github.com/libguestfs/libguestfs-common/commit/12f3fb0f6ccdacb4c6...