On 08/19/2018 01:37 PM, Richard W.M. Jones wrote:
On Sun, Aug 19, 2018 at 07:56:51PM +0300, Nir Soffer wrote:
This version addresses comments on v3.
Changes since v3: - Finally got spacing right (Eric) - Reorder includes (Richard) - Return 0 or -1 instead of r (Richard) - Add common/include/isaligned.h to Makefile.am (Richard)
v3 was here: https://www.redhat.com/archives/libguestfs/2018-August/msg00177.html
Nir Soffer (4): file: Avoid unsupported fallocate() calls file: Support zero without ZERO_RANGE common: Add isaligned helper module file: Zero for block devices on old kernels
I pushed the isaligned change.
The others all look fine to me now, and I would push them but I think it's better to get Eric to check them over first.
I'm okay with the rest, so I've pushed them. Thanks again for bearing with our delays in reviewing this. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org