On Mon, Jul 30, 2018 at 09:52:46AM -0500, Eric Blake wrote:
On 07/29/2018 06:35 AM, Nir Soffer wrote:
On RHEL 7.5 we need to include <linux/falloc.h> for FALLOC_FL_* macros. Without the macros, fallocate is never used and we fall back to manual zeroing.
@@ -41,6 +41,7 @@ #include <sys/types.h> #include <sys/stat.h> #include <errno.h> +#include <linux/falloc.h> /* For FALLOC_FL_* on RHEL, glibc < 2.18 */
This header is not available on all platforms; does it need a configure check, or do we not care about non-Linux compilation?
We should care about at least the *BSDs. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org