On Wed, Jun 17, 2020 at 12:23:12PM +0100, Richard W.M. Jones wrote:
I pushed 2 & 3, thanks.
But ...
From 9fa3e443467e3c06761ec54241327e8daf8701ca Mon Sep 17 00:00:00 2001 From: Alan Somers <asomers@gmail.com> Date: Mon, 15 Jun 2020 16:59:53 -0600 Subject: [PATCH 1/3] Add a Cargo.toml file to the top-level directory
This is necessary for other Rust projects to depend on unrelesed versions of the nbdkit crate. --- Cargo.toml | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 Cargo.toml
diff --git a/Cargo.toml b/Cargo.toml new file mode 100644 index 00000000..f50a66b7 --- /dev/null +++ b/Cargo.toml @@ -0,0 +1,2 @@ +[workspace] +members = ["plugins/rust"]
Is it really absolutely necessary to have this in the top level directory of the source tree?
These seem to be relevant: https://stackoverflow.com/questions/46786956/can-i-add-a-dependent-crate-tha... which refers to: https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html It seems like cargo should pick up the Cargo.toml file from plugins/rust automatically? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top