On Friday, 5 July 2019 06:28:12 CEST Hiroyuki Katsura wrote:
Have you decided whether we need to commit the generated files (Cargo.toml, Cargo.lock)? It looks like in this series those files are still included and not added to .gitignore.
I'm sorry I forgot adding Cargo.lock to .gitignore. I'll add it to .gitignore. However, I think Cargo.toml should be staged. This is because this is a file managed by hands. It contains dependencies, versions, editions, crate name. It can be generated by shellscript which dumps such information. However, I think it may be not preferable.
Hmm, according to this official FAQ https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-v... the Cargo.lock file ought to be shipped only for binaries, and not for libraries (like the libguestfs binding). -- Pino Toscano