On 11/21/2017 04:31 AM, Richard W.M. Jones wrote:
ACK series.
I'll do an upstream release once you've pushed this.
I've pushed the two series that you've reviewed, and have finally posted my parallel nbd series; once that is reviewed, I agree that we are ready for a release. There's other things that may still be worth adding to the nbd forwarder over time (auto-fragmenting of large requests down to the 32M limits mentioned in the spec, or even configurable down to the 1M limit of ancient qemu 2.5; allowing a TCP address and port rather than just a Unix socket; incorporating TLS client communications to allow 'old client => Unix => nbd => encrypted TCP => new server' as a nice counterpart to our existing 'new client => encrypted TCP => nbd => Unix => old server'; implementing upstream NBD extensions such as NBD_OPT_GO support) - but I don't plan to write them this week, so they aren't a reason to hold up an upstream release. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org