On 09/23/22 12:14, Laszlo Ersek wrote:
On 09/23/22 11:54, Richard W.M. Jones wrote:
ACK series, but see my comment about patch 14.
Thanks, I'll adjust patch 14 before pushing (I believe I now understand the borders in the docs).
Commit range aa36551e515f..28d7ce8c9db9. I added the following note to patch#14: [lersek@redhat.com: refresh the disk/network configuration dialog's width in the manual; also replacing an incorrectly used pipe sign (U+007C, Vertical Line) with U+2502 (Box Drawings Light Vertical) ] And the cumulative difference between the posted version and the merged version of the series is:
diff --git a/virt-p2v.pod b/virt-p2v.pod index 2260c6b44d84..ecdae46eaaf6 100644 --- a/virt-p2v.pod +++ b/virt-p2v.pod @@ -189,17 +189,17 @@ disks, removable media devices, and network interfaces, will be created in the output guest. Normally leaving these at the default settings is fine.
- ─ ─ ───────────────────────────────────────┐ - Fixed hard disks │ - │ - Convert Device │ - [✔] sda │ - 1024G HITACHI │ - s/n 12345 │ - [✔] sdb │ - 119G HITACHI │ - s/n 12346 │ - │ + ─ ─ ──────────────────────────────────────────────────┐ + Fixed hard disks │ + │ + Convert Device │ + [✔] sda │ + 1024G HITACHI │ + s/n 12345 │ + [✔] sdb │ + 119G HITACHI │ + s/n 12346 │ + │
Normally you would want to convert all hard disks. If you want virt-p2v to completely ignore a local hard disk, uncheck it. The hard @@ -207,12 +207,12 @@ disk that contains the operating system must be selected. If a hard disk is part of a RAID array or LVM volume group (VG), then either all hard disks in that array/VG must be selected, or none of them.
- │ - Removable media │ - │ - Convert Device │ - [✔] sr0 │ - │ + │ + Removable media │ + │ + Convert Device │ + [✔] sr0 │ + │
If the physical machine has CD or DVD drives, then you can use the Removable media panel to create corresponding drives on the guest @@ -229,13 +229,13 @@ the kernel (such as L<LUNs from iSCSI targets|/ACCESSING ISCSI DEVICES>), and the C<Refresh disks> button allows virt-p2v to learn about all the block devices again.
- │ - Network interfaces │ - │ - Convert Device Connect to ... | - [✔] em1 [default_____________] │ - [ ] wlp3s0 [default_____________] │ - │ + │ + Network interfaces │ + │ + Convert Device Connect to virtual network │ + [✔] em1 [default________________________] │ + [ ] wlp3s0 [default________________________] │ + │
In the Network interfaces panel, select the network interfaces that should be created in the guest after conversion. You can also connect @@ -249,10 +249,10 @@ the interface to be identified by the operator. When you are ready to begin the conversion, press the C<Start conversion> button:
- │ - [ Back ] [ Refresh disks ] [ Start conversion ] │ - │ - ─ ─ ──────────────────────────────────────────────────────────┘ + │ + [ Back ] [ Refresh disks ] [ Start conversion ] │ + │ + ─ ─ ──────────────────────────────────────────────────┘
=head2 CONVERSION RUNNING DIALOG
This update was a bit trickier than I had expected. First, I realized I could compress the extended button row to the left (sticking with the layout seen with the "Fixed hard disks" label; that is, the first button starts where the continuous horizontal line starts). Second, I had to double-check the GUI regarding the "Network interfaces" panel: the network name text entries extend to the very right, so I had to extend those in the manual too, not just move the border to the right. Third, with the extra space available, I had to spell out the full label "Connect to virtual network". Fourth, while looking at the diff closely, I noticed that the original line saying "Connect to ..." used a pipe character (|) for the right border (nowhere else seen in the manual), so I updated that to a U+2502 code point (used everywhere else) at once. ... I kind of wish the manual weren't this extensive; the more docs we have, the more need for updates is "generated" whenever we touch the code somewhere... In effect we have to hand-translate the GTK widget-filling logic to unicode diagrams in the manual. Laszlo