The upstream Yara project has always provided its "libyara/yara.pc.in" file with "Name: yara" -- ever since its introduction in commit 334bd1a671ca ("Add support for pkg-config", 2015-01-08). In spite of this, when the (optional) Yara dependency was added to libguestfs in commit 2e24129da376 ("appliance: add yara dependency", 2017-05-02), PKG_CHECK_MODULES was invoked with [libyara] as list-of-modules. (That was clearly a bug. I'm unsure what Debian calls their Yara pkg-config module, but calling it anything else than "yara" would be a distribution bug: upstream projects provide pkg-config files specifically so that dependent projects can find their dependencies *regardless of distribution*.) As a consequence, on Fedora today, the PKG_CHECK_MODULES macro always fails, and only the AC_CHECK_LIB / AC_CHECK_HEADER branch finds Yara. In a subsequent patch, we'll want to add a version requirement to the PKG_CHECK_MODULES macro invocation, so at first, fix the pkg-config identifier of Yara. Fixes: 2e24129da37656706b5a1d3b6bc83d4c089740bb Signed-off-by: Laszlo Ersek <lersek@redhat.com> --- m4/guestfs-daemon.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/guestfs-daemon.m4 b/m4/guestfs-daemon.m4 index 1728249a5fb7..0790f8848249 100644 --- a/m4/guestfs-daemon.m4 +++ b/m4/guestfs-daemon.m4 @@ -134,7 +134,7 @@ AC_CHECK_LIB([tsk],[tsk_version_print],[ ],[AC_MSG_WARN([The Sleuth Kit library (libtsk) not found])]) dnl yara library (optional) -PKG_CHECK_MODULES([YARA], [libyara],[ +PKG_CHECK_MODULES([YARA], [yara],[ AC_SUBST([YARA_CFLAGS]) AC_SUBST([YARA_LIBS]) AC_DEFINE([HAVE_YARA],[1],[yara library found at compile time.]) -- 2.19.1.3.g30247aa5d201