On Thursday, 19 January 2017 11:24:36 CET Richard W.M. Jones wrote:
From: Pino Toscano <ptoscano@redhat.com>
If the device name ends with a number, Linux uses partition names of the form <device>p<N>. Handle this case by knocking off the 'p' character. --- daemon/devsparts.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/daemon/devsparts.c b/daemon/devsparts.c index 5862ae2..b764f63 100644 --- a/daemon/devsparts.c +++ b/daemon/devsparts.c @@ -203,6 +203,9 @@ do_part_to_dev (const char *part) return NULL; }
Can you please add here a small comment for the if that follow? I.e. something like: /* Deal with <device>p<N> partition names. */
+ if (part[n-1] == 'p') + n--; + char *r = strndup (part, n); if (r == NULL) { reply_with_perror ("strdup");
LGTM with the small addition above. Thanks, -- Pino Toscano