On 04/02/10 09:51, Richard W.M. Jones wrote:
On Mon, Feb 01, 2010 at 05:23:33PM +0000, Matthew Booth wrote:
@@ -393,11 +394,6 @@ sub _unconfigure_xen { my ($guestos, $desc) = @_;
- carp("unconfigure called without guestos argument") - unless defined($guestos); - carp("unconfigure called without desc argument") - unless defined($desc); - my $found_kmod = 0;
What was the point of removing these checks?
They were used inconsistently. I originally put them in when the 'external' interface was larger, and I only put them on the external interface. I've been removing them for internal calls. These checks are really just a way to get round perl's inability to check functions calls at 'compile' time. In practice, though, the lack of type information makes them of limited use. For example, if I changed the second argument to be a Sys::Virt handle, it wouldn't notice. In practise, they haven't been catching the errors I've actually been making. In short, I've gone off these checks. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490