Thanks: Eric Blake for suggesting the test. --- tests/Makefile.am | 4 +- tests/test-partition2.sh | 87 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 90 insertions(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 18936e4..0db5045 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -795,7 +795,9 @@ test_offset_LDADD = libtest.la $(LIBGUESTFS_LIBS) TESTS += test-offset2.sh # partition filter test. -TESTS += test-partition1.sh +TESTS += \ + test-partition1.sh \ + test-partition2.sh # truncate filter tests. TESTS += \ diff --git a/tests/test-partition2.sh b/tests/test-partition2.sh new file mode 100755 index 0000000..71bac55 --- /dev/null +++ b/tests/test-partition2.sh @@ -0,0 +1,87 @@ +#!/usr/bin/env bash +# nbdkit +# Copyright (C) 2018-2019 Red Hat Inc. +# All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions are +# met: +# +# * Redistributions of source code must retain the above copyright +# notice, this list of conditions and the following disclaimer. +# +# * Redistributions in binary form must reproduce the above copyright +# notice, this list of conditions and the following disclaimer in the +# documentation and/or other materials provided with the distribution. +# +# * Neither the name of Red Hat nor the names of its contributors may be +# used to endorse or promote products derived from this software without +# specific prior written permission. +# +# THIS SOFTWARE IS PROVIDED BY RED HAT AND CONTRIBUTORS ''AS IS'' AND +# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, +# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A +# PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL RED HAT OR +# CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF +# USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND +# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, +# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT +# OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF +# SUCH DAMAGE. + +source ./functions.sh +set -e +set -x + +# Test that qemu-img is available and working. +if ! qemu-img --help >/dev/null; then + echo "$0: missing or broken qemu-img" + exit 77 +fi + +files="partition2.log" +rm -f $files +cleanup_fn rm -f $files + +# Select partition 3 from a 2 partition disk. +nbdkit -U - -r -f -v --filter=partition \ + partitioning disk disk partition-type=mbr partition=3 \ + --run 'qemu-img info $nbd' > partition2.log 2>&1 ||: + +cat partition2.log + +grep "MBR partition 3 not found" partition2.log + +# Selection partition 11 from a 9 partition disk. NB: partition 4 is +# the extended partition so it is skipped. This test is slightly +# different from above as it invokes the code supporting logical +# partitions. +nbdkit -U - -r -f -v --filter=partition \ + partitioning disk disk disk disk disk disk disk disk disk \ + partition-type=mbr partition=11 \ + --run 'qemu-img info $nbd' > partition2.log 2>&1 ||: + +cat partition2.log + +grep "MBR partition 11 not found" partition2.log + +# It should be impossible to select an extended partition. +nbdkit -U - -r -f -v --filter=partition \ + partitioning disk disk disk disk disk partition-type=mbr partition=4 \ + --run 'qemu-img info $nbd' > partition2.log 2>&1 ||: + +cat partition2.log + +grep "MBR partition 4 not found" partition2.log + +# Selecting a logical partition on a disk without an extended +# partition gives a different error. +nbdkit -U - -r -f -v --filter=partition \ + partitioning disk disk partition-type=mbr partition=5 \ + --run 'qemu-img info $nbd' > partition2.log 2>&1 ||: + +cat partition2.log + +grep "there is no extended partition" partition2.log -- 2.20.1