On Mon, Nov 01, 2021 at 09:32:37AM +0000, Daniel P. Berrangé wrote:
On Sun, Oct 31, 2021 at 06:20:05PM +0000, Richard W.M. Jones wrote:
On Sun, Oct 31, 2021 at 06:59:32PM +0200, Nir Soffer wrote:
Having different license for the tests complicates everyone life for no benefit. Change the license to LGPL2+ like the rest of the library.
Related discussion: https://listman.redhat.com/archives/libguestfs/2021-October/msg00196.html
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
I agree with this change.
Since this involves some code that I wrote originally, can you add:
Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
However I'm not the only author here (by quite a lot!):
$ git shortlog -s golang/src/libguestfs.org/libnbd/ 13 Eric Blake 2 Nir Soffer 4 Richard W.M. Jones
so could be a good idea to ask Eric specifically for permission too (even though in both cases the © is likely assigned to Red Hat as our employer).
Looking at libnbd.git as a whole I see
1 Author: anson <83398016+anson-lo@users.noreply.github.com> 1 Author: Chris Lamb <lamby@debian.org> 324 Author: Eric Blake <eblake@redhat.com> 1 Author: Laszlo Ersek <lersek@redhat.com> 52 Author: Martin Kletzander <mkletzan@redhat.com> 5 Author: Nir Soffer <nirsof@gmail.com> 33 Author: Nir Soffer <nsoffer@redhat.com> 2 Author: Pino Toscano <ptoscano@redhat.com> 936 Author: Richard W.M. Jones <rjones@redhat.com>
only two patches from non-Red Hat people, and both of those patches are trivial bug fixes so could be said to be non-copyrigtable changes. With this in mind, I would suggest that it is viable to remove all the license headers across the codebase and add SPDX tags in their place.
While viable, we did discuss this already and decided against it for now -- we'll watch what qemu & libvirt are doing. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top