On Thu, Aug 25, 2016 at 05:29:49PM +0200, Pino Toscano wrote:
On Thursday, 25 August 2016 15:53:32 CEST Richard W.M. Jones wrote:
By adding common CLEANFILES and DISTCLEANFILES variables to common-rules.mk, we can remove these from most other Makefiles, and also clean files more consistently.
Note that bin_PROGRAMS are already cleaned by 'make clean', so I removed cases where these were unnecessarily added to CLEANFILES. ---
Mostly LGTM, just a couple of small notes below.
+# Files that should universally be removed by 'make clean'. Note if +# there is any case in any subdirectory where a file should not be +# removed by 'make clean', it should not be listed here! + +# Emacs backup files
It isn't only Emacs doing this kind of backup files :)
OK, I changed it to the more neutral "Editor backup files".
+# Libtool cruft. +CLEANFILES += *.lo *.la
Is this actually needed? Most probably automake already clean them, I think.
Yes it does -- removed. It also removes *.o files, but doesn't appear to remove *.a files ... Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org