Re: [Libguestfs] [PATCH 1/2] file: Add missing include for FALLOC_FL_*

On 07/29/2018 06:35 AM, Nir Soffer wrote:

On RHEL 7.5 we need to include <linux/falloc.h> for FALLOC_FL_* macros. Without the macros, fallocate is never used and we fall back to manual zeroing.

@@ -41,6 +41,7 @@ #include <sys/types.h> #include <sys/stat.h> #include <errno.h> +#include <linux/falloc.h> /* For FALLOC_FL_* on RHEL, glibc < 2.18 */

This header is not available on all platforms; does it need a configure check, or do we not care about non-Linux compilation? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org