On Tue, Oct 20, 2015 at 07:56:02PM +0300, Roman Kagan wrote:
On Tue, Oct 20, 2015 at 05:31:19PM +0100, Richard W.M. Jones wrote:
I'd be tempted just to roll these into a single commit TBH, since they all relate to a single feature.
I thought it was easier to review separately.
Want me to resubmit the combined patch?
No it'll be fine.
I'm just running tests + the full external test suite on it now, and
I'm curious if this external test suite is opensource (or open data, as it's probably mostly data-driven)?
It's unfortunately closed data, not because there is anything particularly hidden about it, but because it contains full disk images from Windows and RHEL. You can download the code (minus only the images themselves) from: http://git.annexia.org/?p=virt-v2v-test-cases-nonfree.git;a=summary Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/