On Thu, Sep 01, 2011 at 10:25:48PM +0100, Richard W.M. Jones wrote:
I think this patch would be better (and much easier to review) if split up into a patch series.
BTW I should say that turning a patch into a patch series is pretty easy with git. You just reset your commit: git reset --mixed HEAD^ and then add the parts and commit them individually. Note the 'add -p' option: git add -p ... git commit -m "blah blah" git add -p ... git commit -m "blah blah" Note each patch should be able to be reviewed as a separate self-consistent unit. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://et.redhat.com/~rjones/virt-df/