On 11/21/2017 01:38 PM, Eric Blake wrote:
On 11/21/2017 04:31 AM, Richard W.M. Jones wrote:
ACK series.
I'll do an upstream release once you've pushed this.
I've pushed the two series that you've reviewed, and have finally posted my parallel nbd series; once that is reviewed, I agree that we are ready for a release.
There's other things that may still be worth adding to the nbd forwarder over time (auto-fragmenting of large requests down to the 32M limits mentioned in the spec, or even configurable down to the 1M limit of ancient qemu 2.5;
Correction - qemu 1.5 had the super-small limit (see qemu commit 2d821488, as well as 476b923c). Hmm - is it time to flip nbdkit to prefer newstyle (rather than oldstyle) as its default? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org