On Tue, Feb 07, 2017 at 04:14:17PM +0100, Cédric Bosdonnat wrote:
To allow other pieces of code to process XML files easily, move the xml.ml* and xpath_helpers.ml* from v2v to mllib.
Strictly speaking this is two commits - the code motion and the addition of Xml.parse_file. However it's a simple enough change. The real problem is this breaks v2v/test-harness. In theory this should fix it: ---------------------------------------------------------------------- --- a/v2v/test-harness/Makefile.am +++ b/v2v/test-harness/Makefile.am @@ -82,7 +82,7 @@ libv2vth_a_CFLAGS = \ -fPIC libv2vth_a_SOURCES = \ - ../xml-c.c + ../../mllib/xml-c.c v2v_test_harness.cmi: $(top_builddir)/ocaml/guestfs.cmi ---------------------------------------------------------------------- but that breaks with some weird automake error: Makefile:1747: ../../mllib/.deps/libv2vth_a-xml-c.Po: No such file or directory which I've no idea how to fix after trying for about an hour. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top