On Tue, Mar 30, 2010 at 05:14:46PM +0100, Matthew Booth wrote:
Allow guests to be written to a RHEV NFS export storage domain.
Add 'rhev' output method and -osd command-line option. Example command line:
virt-v2v -f virt-v2v.conf -ic 'esx://yellow.rhev.marston/' \ -o rhev -osd blue:/export/export RHEL3-32
This will connect to an ESX server and write the guest 'RHEL3-32' to blue:/export/export, which is a pre-initialised RHEV export storage domain.
+ open($uuidgen, '<', '/proc/sys/kernel/random/uuid') + or die("Unable to open /proc/sys/kernel/random/uuid: $!");
This really exists? I'd be inclined to use the uuidgen command. It probably does the same thing, but I bet it's much more portable.
+package Sys::VirtV2V::Target::RHEV::NFSHelper;
What's the purpose of this module? It forks and changes EUID/EGID, then runs a command, then execs /bin/true. I couldn't understand why it doesn't just run the command directly, with a wrapper around that to change EUID/EGID, ie. what is the reason for forking? Anyhow, the OVF may be hideous, but the general outline of this patch is fine, so ACK. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones New in Fedora 11: Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 70 libraries supprt'd http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw