[Libguestfs] [PATCH v3 00/22] Replace almost all uses of the Str module with PCRE.

v1: https://www.redhat.com/archives/libguestfs/2017-September/msg00135.html v2: https://www.redhat.com/archives/libguestfs/2017-September/msg00158.html v3 is almost identical to v2, but I have added 4 extra commits to almost finish the job of replacing Str everywhere possible (note it's not possible to replace Str in common/mlstdutils or the generator because those are pure OCaml). As before there is an outstanding question:

I wonder if there was a deep reason why we had this?

let unix2dos s = String.concat "\r\n" (Str.split_delim (Str.regexp_string "\n") s)

I replaced it with what I think should be (nearly) equivalent:

let unix2dos s = String.concat "\r\n" (String.nsplit "\n" s)

Rich.